fix(playground): don't extract inline css #9203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://mozilla-hub.atlassian.net/browse/MP-515 #9190 inline bits of css get a `css` class applied to them, so our extraction logic was treating them as "normal" css - which of course it isn't, since it doesn't have any kind of selector
fiji-flo
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://mozilla-hub.atlassian.net/browse/MP-515
fixes #9190
Problem
inline bits of css get a
cssclass applied to them, so our extraction logic was treating them as "normal" css - which of course it isn't, since it doesn't have any kind of selectorSolution
specifically target
pre.${language_name}rather than just.${language_name}- I'm going to wait for your review @fiji-flo here, because I imagine there was a reason you chose not to specifically target pre tags, so I want to make sure I'm not breaking anything elseScreenshots
Before
After
How did you test this change?
http://localhost:3000/en-US/docs/Web/CSS/flex-grow